Improve KBS protocol version handling and bump the version to v0.1.1 due to kbs-types changes #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mythi
force-pushed
the
deps-kbs-types
branch
4 times, most recently
from
622fe89 to
39ed94d
Compare
|
whoops, didn't mean to make this ready for review |
|
This PR now depends on getting confidential-containers/trustee#449 merged and released with |
|
mythi
changed the title
mythi
force-pushed
the
deps-kbs-types
branch
2 times, most recently
from
10a95c5 to
783b154
Compare
|
@Xynnn007 PTAL also |
mkulke
reviewed
Aug 6, 2024
mkulke
reviewed
Aug 6, 2024
mkulke
approved these changes
Aug 6, 2024
fitzthum
reviewed
Aug 6, 2024
Signed-off-by: Mikko Ylinen <[email protected]>
The RCAR client code currently ignores any errors for "request". Such errors can still happen, e.g., when 'version' field is rejected by KBS. Without catching errors we try to decode the Challenge json body but it actually contains the error information in it which results in decode errors instead. KBS added a new ProtocolVersion error which is now catched by the RCAR client code. The error is reported to the user if the client and server use incompatible versions. Signed-off-by: Mikko Ylinen <[email protected]>
The current setup with trustee repo for KBS server and guest-components repo for kbs_protocol client code has a cyclic dependency problem. test_client test uses "KBS latest" container image which won't work if any RCAR client code changes that change the protocol semantics are made. The suggested approach to break the cyclic dependency is to get the RCAR client changes merged first with a KBS protocol version bump. The RCAR client test is modified to skip the checks in case the "KBS latest" server returns ProtocolVersion error. Following this, the corresponding KBS server changes are made in trustee repo with an update to both kbs_protocol for kbs-client builds and the server supported protocol version. Signed-off-by: Mikko Ylinen <[email protected]>
kbs-types introduces a break in JSON semantics so we bump the kbs protocol version from 0.1.0 to 0.1.1. Signed-off-by: Mikko Ylinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in @Xynnn007's work for confidential-containers/trustee#242 (comment)